Skip to content

Upgrade to webpack 5 with jQuery fallback and plugin improvements#7

Merged
mpchadwick merged 7 commits into
sdinteractive:masterfrom
dheerajsharmaRP:fix/jquery-fallback
Jun 17, 2026
Merged

Upgrade to webpack 5 with jQuery fallback and plugin improvements#7
mpchadwick merged 7 commits into
sdinteractive:masterfrom
dheerajsharmaRP:fix/jquery-fallback

Conversation

@dheerajsharmaRP

Copy link
Copy Markdown
Contributor

No description provided.

@dheerajsharmaRP dheerajsharmaRP changed the title Add jQuery fallback for RequireJS loader Upgrade to webpack 5 with jQuery fallback and plugin improvements Jun 16, 2026
@mohit-sharma-rp
mohit-sharma-rp requested a review from Copilot June 17, 2026 04:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the requirejs-loader package to support webpack 5 (while retaining webpack 4 support), and adds a jQuery runtime fallback to use an existing global window.jQuery/window.$ when available.

Changes:

  • Add a webpack 5-compatible implementation of RequireJsLoaderPlugin using compilation.hooks.processAssets.
  • Normalize loader behavior and add a special-case runtime fallback for jquery.
  • Bump package version to 4.0.0 and update the package description to reflect webpack 4/5 support.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
RequireJsLoaderPlugin.js Adds webpack 5 processAssets integration and refactors module filtering logic.
index.js Normalizes request names and adds jquery fallback to global jQuery before calling window.require().
package.json Major version bump + description update for webpack 4/5 support.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread RequireJsLoaderPlugin.js
Comment thread RequireJsLoaderPlugin.js
Comment thread RequireJsLoaderPlugin.js

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Comment thread RequireJsLoaderPlugin.js
Comment thread RequireJsLoaderPlugin.js
Comment thread index.js
Comment thread index.js Outdated
Comment thread package.json

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@mpchadwick
mpchadwick merged commit 8a6f07e into sdinteractive:master Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants