Update save_resource to handle downloading resources in nested folders - #2931
Merged
gsheni merged 4 commits intoJul 23, 2026
Merged
Conversation
Contributor
gsheni
changed the title
save_resource to support filepaths and filenames under demo datasetsave_resource to handle downloading resources in nested folders
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2931 +/- ##
==========================================
+ Coverage 98.07% 98.08% +0.01%
==========================================
Files 73 73
Lines 8513 8531 +18
==========================================
+ Hits 8349 8368 +19
+ Misses 164 163 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pvk-developer
approved these changes
Jul 23, 2026
frances-h
reviewed
Jul 23, 2026
frances-h
reviewed
Jul 23, 2026
Comment on lines
893
to
894
| output_filepath (str or None): | ||
| Optional path where to save the file. |
Contributor
There was a problem hiding this comment.
This docstring should be updated since we're not allowing output_filepath to be None
frances-h
approved these changes
Jul 23, 2026
gsheni
deleted the
issue-2917-the-save_resource-for-demo-datasets-filepath
branch
July 23, 2026 16:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save_resourcefor demo datasets should be able to handle filepaths (not just filenames) #2917