tool(sdf): split into files - #581
Merged
Merged
Conversation
midnightveil
force-pushed
the
julia/sdf-split
branch
from
July 27, 2026 05:04
c49a564 to
915b570
Compare
Cleanup. Signed-off-by: Julia Vassiliki <julia.vassiliki@unsw.edu.au>
midnightveil
force-pushed
the
julia/sdf-split
branch
from
July 27, 2026 05:05
915b570 to
6a18dd7
Compare
dreamliner787-9
approved these changes
Jul 27, 2026
|
I was about to suggest to split the big files up to reduce the number of merge conflicts and to make things more manageable. |
Collaborator
Author
|
Yes, for some reason the Microkit tool has tended to generate a lot of large files. Probably because everything started without structure and there was no definite tipping point to adding more being too much. |
|
It's something you have to be aware of and check every time you add code to an existing function or file: Does it need splitting up? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup.