feat!: upgrade to @seamapi/http v2 and drop @seamapi/types - #19
Merged
Conversation
@seamapi/http v2 vendors the API types directly, so ActionAttempt is now imported from the package root instead of @seamapi/types/connect, and @seamapi/types is removed from both peerDependencies and devDependencies. BREAKING CHANGE: @seamapi/http ^2.5.0 is now required as a peer dependency. The isUndocumentedApiEnabled option was removed upstream in v2, so it is no longer accepted by SeamQueryProvider. SeamHttpEndpoints.fromClient no longer accepts client-construction options in v2; the endpoint is already bound to the client being passed in, so the argument is dropped. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fomny7NLXuNediSKrgmbTH
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Passing client-construction options to SeamHttpEndpoints.fromClient throws
SeamHttpInvalidOptionsError ("The client option cannot be used with any other
option, but received: endpoint"), since the endpoint is already bound to the
axios client being handed in. Setting the endpoint prop on SeamQueryProvider
therefore left both clients null.
The endpoint is still applied where it always was, when constructing the
SeamHttp instance, and carries over to the endpoint client through the shared
axios instance.
Resolve tsconfig paths in vitest so tests exercise src rather than resolving
the package self-reference to build output, which is absent in CI.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fomny7NLXuNediSKrgmbTH
This reverts commit 3a3938e. Keeps the branch scoped to the @seamapi/http v2 upgrade. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fomny7NLXuNediSKrgmbTH
Vitest resolved @seamapi/react-query through the package self-reference in exports, loading build output instead of src. That output is gitignored and absent in CI, where npm test runs without a build step. Mirror the tsconfig paths as explicit Vitest aliases. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fomny7NLXuNediSKrgmbTH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@seamapi/http v2 vendors the API types directly, so ActionAttempt is now
imported from the package root instead of @seamapi/types/connect, and
@seamapi/types is removed from both peerDependencies and devDependencies.
BREAKING CHANGE: @seamapi/http ^2.5.0 is now required as a peer dependency.
The isUndocumentedApiEnabled option was removed upstream in v2, so it is no
longer accepted by SeamQueryProvider.
SeamHttpEndpoints.fromClient no longer accepts client-construction options in
v2; the endpoint is already bound to the client being passed in, so the
argument is dropped.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01Fomny7NLXuNediSKrgmbTH