feat: Show access code errors and warnings in AccessCodeDetails
#243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or `failed_to_remove_on_device`
… into add-access-code-errs-warns
… into add-access-code-errs-warns
… into add-access-code-errs-warns
dawnho
reviewed
Jun 28, 2023
src/lib/seam/components/AccessCodeDetails/AccessCodeDetails.tsx
Outdated
Show resolved
Hide resolved
dawnho
reviewed
Jun 28, 2023
src/lib/seam/components/AccessCodeDetails/AccessCodeDetails.tsx
Outdated
Show resolved
Hide resolved
razor-x
reviewed
Jun 28, 2023
Member
razor-x
left a comment
razor-x
left a comment
There was a problem hiding this comment.
Will approve when SDK update is in
src/lib/seam/components/AccessCodeDetails/AccessCodeDetails.tsx
Outdated
Show resolved
Hide resolved
src/lib/seam/components/AccessCodeDetails/AccessCodeDetails.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Evan Sosenko <evan@getseam.com>
… into add-access-code-errs-warns
… into add-access-code-errs-warns
razor-x
approved these changes
Jun 28, 2023
| const errorFilter = ( | ||
| error: AccessCodeError | DeviceError | ConnectedAccountError | ||
| ): boolean => { | ||
| if ('is_access_code_error' in error && !error.is_access_code_error) |
Member
There was a problem hiding this comment.
Nice. This makes me think we need to add type guards to the SDK for the different error types like we have for managed and unmanaged devices.
Contributor
Author
There was a problem hiding this comment.
Yep, that's a good idea!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #239 • Should be good to merge after SDK updates, which are waiting on https://github.com/seamapi/seam-connect/issues/3455 (tests are expected to fail until then).