-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Show access code errors and warnings in AccessCodeDetails
#243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
a53d9ac
feat: Show access code `errors` and `warnings` in `AccessCodeDetails`
xplato 94b551c
Run format
seambot d28251c
fix: Filter out `is_access_code_error` except `failed_to_set_on_device`
xplato f6e9388
Merge branch 'add-access-code-errs-warns' of github.com:seamapi/react…
xplato 08888cf
Run format
seambot f807880
fix: Remove top padding of `.seam-alerts-padded`
xplato aa549ca
Merge branch 'add-access-code-errs-warns' of github.com:seamapi/react…
xplato 49d9165
fix: Adjust padding to match design spec
xplato aaf6b1d
fix: Update `Alert` style
xplato 5ebf1c5
Run format
seambot f983d0a
fix: Revert `Alert` changes in favor of #244
xplato 8e3ea34
Merge branch 'add-access-code-errs-warns' of github.com:seamapi/react…
xplato aa97aa0
Merge branch 'main' into add-access-code-errs-warns
xplato 87fb781
Merge branch 'main' into add-access-code-errs-warns
xplato ea05f15
fix: Remove undefined operators for `errors`, `warnings`
xplato 14c37a3
fix: Update condition style
xplato bc31547
Run format
seambot 569e831
Merge branch 'main' into add-access-code-errs-warns
xplato 7b8d5dc
fix: Update condition for linter happiness
xplato 73b8a01
fix: Use `errorFilter`
xplato e7ba7c4
Merge branch 'add-access-code-errs-warns' of github.com:seamapi/react…
xplato adde876
Run format
seambot 47cf976
fix: Move `errorFilter` to bottom of file
xplato 30a24f8
Merge branch 'add-access-code-errs-warns' of github.com:seamapi/react…
xplato 6d29cad
Run format
seambot 563744b
fix: Update `is_access_code_error` condition
xplato 4d3a058
fix: Update `account_disconnected` error properties
xplato File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. This makes me think we need to add type guards to the SDK for the different error types like we have for managed and unmanaged devices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's a good idea!