Use usbi_ helper functions behind macro aliases - #1
Closed
Youw wants to merge 4 commits into
Closed
Conversation
- For USBI_TRANSFER_TO_TRANSFER_PRIV use void* as the return type since indeed the struct is different for each backend, and not a char* - For USBI_TRANSFER_TO_LIBUSB_TRANSFER, use the size from usbi_backend.transfer_priv_size, just like the inverse macro does. This makes things symetric and makes it possible to convert this to a function since `struct usbi_transfer` is not a macro parameter, but just resolved after preprocessing
Only 1 caller needed to be changed, since it was not acting as a function. Functions provide type safety vs macros, and macros are renowned footguns.
Assisted-by: Codex:GPT-5
Author
|
I see you've implemented on your own, closing |
Owner
It was faster than figuring out the necessary git commands. I copy pasted your backwards compatible macros though, thanks for making them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the parent PR's new static inline helpers to lower_snake_case
usbi_*names.Keeps each existing uppercase macro as a forwarding alias, so in-tree macro call sites and existing private-header consumers retain their current spelling.
Related to libusb#1729
Assisted-by: Codex:GPT-5