do not configure logging on import, use named logger - #116
Merged
Conversation
`convert_airtable.py` was configuring the logger for the root level, which clashes with other loggers that are properly configured via a logging dict, like how it's done normally in applications like django. In applications that configure their own logging this caused duplicated log lines and third-party output in seatable's format. It should be possible to toggle seatable_api logging on explicitly if it's needed. In general, libraries should only configure their own named logging space. See https://docs.python.org/3/howto/logging.html#configuring-logging-for-a-library
seafile-dev
reviewed
Sep 4, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
Verdict: Comment
Warnings:
- 缺少覆盖本次日志隔离行为的回归测试；已在行内评论说明。
Suggested fix: 新增独立进程测试，断言导入seatable_api.convert_airtable不调用logging.basicConfig、不修改 root logger，并且模块 logger 名称位于seatable_api命名空间。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convert_airtable.pywas configuring the logger for the root level, which clashes with other loggers that are properly configured via a logging dict, like how it's done normally in applications like django.In applications that configure their own logging this caused duplicated log lines and third-party output in seatable's format.
It should be possible to toggle only the seatable_api log on explicitly if it's needed.
In general, libraries should only configure their own named logging space.
See https://docs.python.org/3/howto/logging.html#configuring-logging-for-a-library