Skip to content

Add logic for leader registrations - #203

Merged
gmcgrady merged 2 commits into
masterfrom
sl-feature-camp-sync
Mar 10, 2026
Merged

Add logic for leader registrations#203
gmcgrady merged 2 commits into
masterfrom
sl-feature-camp-sync

Conversation

@stphnlee

Copy link
Copy Markdown
Contributor

The workflow action had been created to find the registration group through the linkage on the registration instance; however, our leader groups are handled through connection requests and aren't linked directly through the registration instance. I added logic to identify if a groupmember hasn't been found through the normal linkage, then to check through the registration workflow which is how we link the leader registrants to their camp group.

…re not linked directly to the registration instance
Copilot AI review requested due to automatic review settings March 10, 2026 19:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the SECC Registrations workflow action to better support “leader” registration scenarios where the person’s registration group membership is not linked through RegistrationRegistrant.GroupMemberId, but instead is inferred via the registration instance’s configured registration workflow type.

Changes:

  • Adds a new optional action setting (WorkflowGroupAttributeKey) to provide a fallback lookup mechanism for leader registrants.
  • Implements fallback logic that, when no linked registration group members are found, reads a WorkflowType-scoped workflow attribute (by key) to identify the registration group and locate the person’s GroupMember record.
  • Introduces a helper method to resolve group membership from the registration instance’s RegistrationWorkflowTypeId configuration.

@stphnlee
stphnlee requested a review from gmcgrady March 10, 2026 20:22

@gmcgrady gmcgrady left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified the role of the WorkflowGroupAttributeKey w/ Stephen. Overall, the branch is solid & ready to merge! An alternative thought could have been to include another attribute on the action & workflow that designates which case (camper or leader) the workflow is associated with; that way, in lieu of waiting for the campers to not be found, we could jump directly to finding the group members for leaders. The alternative idea would only be possible if we can identify the case (camper or leader) at time of placement. That said, this PR more than achieves what we need. Approving & merging.

@gmcgrady
gmcgrady merged commit 630792d into master Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants