New ServerHealth Block - #205
Merged
Merged
Conversation
…ck is running before returning that the server is healthy
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Rock block (ServerHealth) to replace the prior ServerHealth.ashx approach, providing a health endpoint/UI that validates key Rock web-farm signals before reporting the node as healthy.
Changes:
- Introduces a new
ServerHealthRock block code-behind that performs maintenance-mode, web-farm heartbeat, message bus, and cache-queue checks. - Adds the corresponding
.ascxmarkup to render health status and details, with a manual refresh action.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| Plugins/org.secc.SystemsMonitor/org_secc/SystemsMonitor/ServerHealth.ascx.cs | Implements health-check logic and sets HTTP status codes (200/503) based on Rock/node health. |
| Plugins/org.secc.SystemsMonitor/org_secc/SystemsMonitor/ServerHealth.ascx | Provides UI layout for displaying health status/details and a refresh button. |
…Health.ascx.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Health.ascx.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Health.ascx.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
gmcgrady
approved these changes
Mar 27, 2026
gmcgrady
left a comment
gmcgrady
left a comment
Contributor
There was a problem hiding this comment.
Addition of the new Rock block appears straight forward. Especially like the use of defined types to store the health check URL as opposed to hard coding or making it a text field configuration. That should make configuring for different environments relatively easy. Approving for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROCK-8397 Converted ServerHealth.ashx into a block to confirm that Rock is running before returning that the server is healthy