ROCK-8362: Sanitize CustomSchedule - #206
Merged
jwakefield-secc merged 2 commits intoApr 2, 2026
Merged
Conversation
…n publish groups - Add FormatScheduleDates() to convert RDATE schedules into readable date lists (e.g., "Tuesdays at 6:30 PM: Aug 5, Aug 19, Sep 2...") - Replace FriendlyScheduleText and iCalendarContent references with FormatScheduleDates - Apply .SanitizeHtml() on save to strip any remaining HTML from CustomSchedule - Add | StripHtml in GroupFinder Lava templates as defense-in-depth - Fix NullReferenceException in OnInit when publishGroup is null
Show first 3 dates + last date for schedules with 5+ specific dates to prevent overly long Custom Schedule text (e.g., "Tuesdays at 6:30 PM: Aug 5, Aug 19, Sep 2, ... Dec 2")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PublishGroup.cs— converts RDATE-based schedules into readable text (e.g., "Tuesdays at 6:30 PM: Aug 5, Aug 19, Sep 2...") instead of storing raw iCal or HTMLFriendlyScheduleText(returns HTML for specific-date schedules) andiCalendarContent(raw iCal) references withFormatScheduleDatesacross all code paths that populateCustomSchedule.SanitizeHtml()applied on save to strip any HTML that might leak through the textbox| StripHtmlfilter added to SECC2019 and SECC2024 GroupFinder templatesOnInitnow guardspublishGroupandpublishGroup.Groupbefore accessingGroupTypeIdTest Link: https://sedev.secc.org/page/2006?PublishGroupId=9044
Files Changed
Plugins/org.secc.GroupManager/Model/PublishGroup.csFormatScheduleDates()method,ScheduleTextgetter sanitizationPlugins/org.secc.GroupManager/org_secc/GroupManager/PublishGroupRequest.ascx.csPlugins/org.secc.Themes/Themes/SECC2019/Assets/Lava/Groups/GroupFinder.lavaPlugins/org.secc.Themes/Themes/SECC2024/Assets/Lava/Groups/GroupFinder.lavaTest Plan