Skip to content

ROCK-8422 Optimized job to reduce webfarm messages - #208

Merged
gmcgrady merged 2 commits into
masterfrom
sl-bugfix-optimize-gls-job
Apr 7, 2026
Merged

ROCK-8422 Optimized job to reduce webfarm messages#208
gmcgrady merged 2 commits into
masterfrom
sl-bugfix-optimize-gls-job

Conversation

@stphnlee

@stphnlee stphnlee commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 7, 2026 18:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Optimizes the ResetGroupLocationSchedules Quartz job to reduce broad cache clears (and resulting webfarm messaging) by batching DB changes and performing more targeted cache invalidation after re-activating group-location schedules.

Changes:

  • Adds an early exit when there are no deactivated schedules to process.
  • Batches DefinedValue deletions + performs a single SaveChanges() before cache work.
  • Replaces global cache clears with targeted updates/flushes for occurrences, kiosk types, and kiosk devices (and intentionally avoids clearing AttendanceCache).

Comment thread Plugins/org.secc.FamilyCheckin/Jobs/ResetGroupLocationSchedules.cs
Comment thread Plugins/org.secc.FamilyCheckin/Jobs/ResetGroupLocationSchedules.cs
Comment thread Plugins/org.secc.FamilyCheckin/Jobs/ResetGroupLocationSchedules.cs Outdated
…s.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@stphnlee
stphnlee requested a review from gmcgrady April 7, 2026 19:38

@gmcgrady gmcgrady left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limiting cache clear operations by tracking affected items should effectively minimize the message load of this job, as expected. Targeting kiosk types by their affectedGroupTypeIds was a particularly clever way of handling this issue. To Stephen's earlier point, this issue could have originated from high Easter volume; however, this narrowed cache clearing strategy is a win, regardless. This implementation is super readable & clear to understand! Approving & merging.

@gmcgrady
gmcgrady merged commit 8d318e9 into master Apr 7, 2026
@stphnlee
stphnlee deleted the sl-bugfix-optimize-gls-job branch April 10, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants