Cert: Tests, Python 3 and Cryptography update#1194
Merged
guedou merged 2 commits intosecdev:masterfrom Mar 1, 2018
gpotter2:tests-cert
Merged
Cert: Tests, Python 3 and Cryptography update#1194guedou merged 2 commits intosecdev:masterfrom gpotter2:tests-cert
guedou merged 2 commits intosecdev:masterfrom
gpotter2:tests-cert
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1194 +/- ##
=========================================
+ Coverage 84.09% 84.3% +0.21%
=========================================
Files 159 159
Lines 38211 38228 +17
=========================================
+ Hits 32133 32230 +97
+ Misses 6078 5998 -80
|
Member
|
@gpotter2 is it related to you cryptography module version ? |
Member
Author
|
@guedou You are right, the API has been updated, and our calls have been deprecated. I've updated the ECDSA functions |
Member
Author
|
Could you please restart the failing build ? Thanks! |
guedou
approved these changes
Feb 28, 2018
Member
Author
|
Well codecov is broken on OSX Python 3 :/ not related to me though |
Member
|
Awesome PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an unknown reason, a few tests are only working locally (not on Appveyor/Travis).
However, they work under Travis Python 3.3
I cannot explain why. They are disabled through the 2nd commit