Decode IPv6 Jumbograms#1196
Merged
p-l- merged 1 commit intosecdev:masterfrom Mar 1, 2018
Merged
Conversation
Member
Author
|
Ready to be merged. The failing AppVeyor is related to nmap. |
Codecov Report
@@ Coverage Diff @@
## master #1196 +/- ##
==========================================
+ Coverage 84.04% 84.09% +0.05%
==========================================
Files 159 159
Lines 38211 38228 +17
==========================================
+ Hits 32114 32148 +34
+ Misses 6097 6080 -17
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a bit tricky as some parsing must be in
IPv6.extract_padding()to retrieve the payload length from the payload itself.