Scapy 2.4.0: Little but obvious code improvements#1226
Merged
guedou merged 1 commit intosecdev:masterfrom Mar 9, 2018
Merged
Conversation
gpotter2
reviewed
Mar 8, 2018
Member
gpotter2
left a comment
gpotter2
left a comment
There was a problem hiding this comment.
Very nice PR ! A few minor comments
Contributor
Author
There was a problem hiding this comment.
Yep. I know, but did not want to change sources to deeply :)
Of course I will change it in next commit.
Member
There was a problem hiding this comment.
In fact, setting timeout to -1 is useless.
Those changes have been removed in #1142
To avoid conflicts, please do not edit it
Codecov Report
@@ Coverage Diff @@
## master #1226 +/- ##
==========================================
+ Coverage 84.75% 84.78% +0.02%
==========================================
Files 159 159
Lines 38247 38210 -37
==========================================
- Hits 32417 32396 -21
+ Misses 5830 5814 -16
|
Closed
karpierz
force-pushed
the
little_but_obvious_code_improvements
branch
from
b19ef99 to
617920f
Compare
Contributor
Author
|
PR is ready for merge. |
Member
|
Thanks for this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scapy Version: 2.4.0rc5-13
System: Windows7/Windows10
Python Version: 2.7.14