Skip to content

Don't crash on empty manufdb#1244

Merged
guedou merged 1 commit intosecdev:masterfrom
guedou:dojo_in6_addrtovendor
Mar 15, 2018
Merged

Don't crash on empty manufdb#1244
guedou merged 1 commit intosecdev:masterfrom
guedou:dojo_in6_addrtovendor

Conversation

@guedou
Copy link
Copy Markdown
Member

@guedou guedou commented Mar 12, 2018

This fixes #1243

Comment thread scapy/utils6.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be wrong, but shouldn’t it be not conf.manufdb ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I should not teach and fix at the same time ....

@guedou guedou force-pushed the dojo_in6_addrtovendor branch from aec3f8f to 5d8645a Compare March 12, 2018 23:39
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 12, 2018

Codecov Report

Merging #1244 into master will decrease coverage by 0.79%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #1244     +/-   ##
=========================================
- Coverage   84.81%   84.02%   -0.8%     
=========================================
  Files         160      159      -1     
  Lines       38291    37538    -753     
=========================================
- Hits        32477    31540    -937     
- Misses       5814     5998    +184
Impacted Files Coverage Δ
scapy/utils6.py 87.75% <100%> (ø) ⬆️
scapy/arch/pcapdnet.py 34.14% <0%> (-34.63%) ⬇️
scapy/consts.py 69.56% <0%> (-21.74%) ⬇️
scapy/pton_ntop.py 89.04% <0%> (-8.22%) ⬇️
scapy/automaton.py 76.27% <0%> (-6.07%) ⬇️
scapy/arch/__init__.py 86% <0%> (-6%) ⬇️
scapy/route.py 85.4% <0%> (-5.11%) ⬇️
scapy/pipetool.py 84.58% <0%> (-5%) ⬇️
scapy/data.py 81.25% <0%> (-2.24%) ⬇️
scapy/sendrecv.py 76.37% <0%> (-1.9%) ⬇️
... and 12 more

@guedou guedou force-pushed the dojo_in6_addrtovendor branch from 5d8645a to d08d9db Compare March 14, 2018 14:37
@guedou guedou merged commit 2c9361b into secdev:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

in6_addrtovendor issue when manufdb is None

3 participants