Write a PCAP header when no packets are provided#1253
Merged
p-l- merged 1 commit intosecdev:masterfrom Mar 24, 2018
Merged
Conversation
Member
|
@guedou this breaks the tests |
Member
Author
|
@p-l- it looks ok now. I moved the unit test to a different location. |
Contributor
Member
|
@guedou Can you rebase against current master? |
Codecov Report
@@ Coverage Diff @@
## master #1253 +/- ##
=========================================
+ Coverage 83.98% 84.98% +1%
=========================================
Files 159 160 +1
Lines 37546 38711 +1165
=========================================
+ Hits 31532 32898 +1366
+ Misses 6014 5813 -201
|
Member
Author
|
@p-l- done! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1242