Fix IPv6 multicast address record#1261
Merged
guedou merged 1 commit intosecdev:masterfrom Mar 18, 2018
gpotter2:hunterbuster
Merged
Fix IPv6 multicast address record#1261guedou merged 1 commit intosecdev:masterfrom gpotter2:hunterbuster
guedou merged 1 commit intosecdev:masterfrom
gpotter2:hunterbuster
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1261 +/- ##
==========================================
+ Coverage 83.98% 84.78% +0.79%
==========================================
Files 159 160 +1
Lines 37546 38299 +753
==========================================
+ Hits 31532 32470 +938
+ Misses 6014 5829 -185
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1260
According to page 20 of https://tools.ietf.org/html/rfc3810, it also seems that we build the packet correctly, even though wireshark fails when using auxiliary data.