Skip to content

support of group management cipher suite in Dot11EltRSN#2600

Closed
ash09 wants to merge 1 commit intosecdev:masterfrom
ash09:master
Closed

support of group management cipher suite in Dot11EltRSN#2600
ash09 wants to merge 1 commit intosecdev:masterfrom
ash09:master

Conversation

@ash09
Copy link
Copy Markdown

@ash09 ash09 commented Apr 20, 2020

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2020

Codecov Report

Merging #2600 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2600      +/-   ##
==========================================
- Coverage   88.47%   88.45%   -0.03%     
==========================================
  Files         246      246              
  Lines       52004    52004              
==========================================
- Hits        46012    46000      -12     
- Misses       5992     6004      +12     
Impacted Files Coverage Δ
scapy/layers/dot11.py 91.40% <ø> (ø)
scapy/arch/pcapdnet.py 79.21% <0.00%> (-1.18%) ⬇️
scapy/supersocket.py 74.20% <0.00%> (-0.64%) ⬇️
scapy/arch/windows/__init__.py 69.95% <0.00%> (-0.64%) ⬇️
scapy/layers/inet.py 72.43% <0.00%> (-0.25%) ⬇️
scapy/sendrecv.py 85.82% <0.00%> (-0.17%) ⬇️
scapy/layers/inet6.py 88.34% <0.00%> (+0.05%) ⬆️

@gpotter2
Copy link
Copy Markdown
Member

Thanks for the PR.
This looks pretty straightforward but:

  • you have a PEP8 failure

scapy/layers/dot11.py:868:80: E501 line too long (101 > 79 characters)

  • could you add a unit test in test/regressions.uts nearby existing Dot11 tests.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants