Implementation of SMB2 headers#2629
Merged
p-l- merged 1 commit intosecdev:masterfrom May 7, 2020
Merged
Conversation
3b9985e to
8e46d38
Compare
Includes: - change guess_payload_class in Packet to handle lambda filters - add NByte and XNBytes fields, StrFieldUtf16 - add tests for SMB2 and for new fields
Codecov Report
@@ Coverage Diff @@
## master #2629 +/- ##
==========================================
- Coverage 88.61% 88.24% -0.38%
==========================================
Files 247 248 +1
Lines 52053 52555 +502
==========================================
+ Hits 46125 46375 +250
- Misses 5928 6180 +252
|
p-l-
approved these changes
May 7, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal implementation for SMB2 headers dissection.
This implementation is based on the official documentation of SMB2, available here.
Note that implementation is minimalistic and does not handle every part of the protocol.
For instance, some fields have been implemented as bytes, but would deserve a specific
Fieldclass, such as the fieldSystemTimeinSMB2_Negociate_Protocol_Response_Headerthat should be parsing the date format: