Retrieve the optimized BPF filter #3446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3446 +/- ##
==========================================
+ Coverage 85.26% 85.30% +0.03%
==========================================
Files 278 278
Lines 57656 57902 +246
==========================================
+ Hits 49162 49391 +229
- Misses 8494 8511 +17
|
Member
Author
|
Should I add a unit test? |
gpotter2
approved these changes
Nov 20, 2021
Member
gpotter2
left a comment
gpotter2
left a comment
There was a problem hiding this comment.
Very nice catch !
I'm pretty sure I didn't read the doc entirely when implementing those.. oops
Member
|
A unit test would be nightmarish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3445. It turns out that Scapy currently injects raw BPF filter that are not optimized by libpcap. That is why the filter used by @janus1345 hits the memory limit while tcpcpdump does not.