Added support for computing invariant CRC over IPv6 #3562
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for your interest in Scapy and this PR. Could you add a unit test to the file roce.uts? |
guedou
reviewed
Apr 5, 2022
| warning(f"The underlayer protocol %s is not supported.", | ||
| ip and ip.name) | ||
| return self.pack_icrc(0) | ||
| return struct.pack("!I", 0 & 0xffffffff)[::-1] |
Member
There was a problem hiding this comment.
Why are you not using pack_icrc(0) here?
Member
|
flake8 is reporting linting errors. Can you fix them? |
Member
|
Closed by #4154. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use the compute_icrc function as a part of a task in my job.
I have added the the IPv6 implementation after it was marked under TODO.
I have read the manual on how to implement it and tested.