Skip to content

Adjust MQTTPublish when underlayer is QOS#3616

Merged
gpotter2 merged 1 commit into
secdev:masterfrom
guedou:issue_3572
Jun 18, 2022
Merged

Adjust MQTTPublish when underlayer is QOS#3616
gpotter2 merged 1 commit into
secdev:masterfrom
guedou:issue_3572

Conversation

@guedou
Copy link
Copy Markdown
Member

@guedou guedou commented May 21, 2022

This PR fixes #3572

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2022

Codecov Report

Merging #3616 (2911689) into master (e674081) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3616   +/-   ##
=======================================
  Coverage   86.18%   86.18%           
=======================================
  Files         285      285           
  Lines       65023    65041   +18     
=======================================
+ Hits        56037    56054   +17     
- Misses       8986     8987    +1     
Impacted Files Coverage Δ
scapy/contrib/mqtt.py 97.34% <ø> (ø)
scapy/arch/windows/__init__.py 67.73% <0.00%> (-0.57%) ⬇️
scapy/contrib/automotive/scanner/enumerator.py 91.96% <0.00%> (-0.30%) ⬇️
scapy/packet.py 82.03% <0.00%> (-0.11%) ⬇️
scapy/fields.py 91.20% <0.00%> (+0.01%) ⬆️
scapy/data.py 88.19% <0.00%> (+0.03%) ⬆️
scapy/contrib/automotive/ecu.py 94.66% <0.00%> (+0.33%) ⬆️
scapy/layers/l2.py 76.85% <0.00%> (+0.97%) ⬆️
scapy/layers/l2tp.py 100.00% <0.00%> (+11.11%) ⬆️

@polybassa polybassa added the bug label May 22, 2022
Copy link
Copy Markdown
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gpotter2 gpotter2 merged commit 07c06ed into secdev:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mistaken msglen in MQTTPublish message

3 participants