Skip to content

Conversation

@gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Mar 2, 2024

@codecov
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Merging #4306 (cd92c32) into master (28c2f78) will decrease coverage by 0.27%.
Report is 1 commits behind head on master.
The diff coverage is 92.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4306      +/-   ##
==========================================
- Coverage   82.01%   81.75%   -0.27%     
==========================================
  Files         350      350              
  Lines       82225    82748     +523     
==========================================
+ Hits        67439    67648     +209     
- Misses      14786    15100     +314     
Files Coverage Δ
scapy/asn1/ber.py 86.38% <100.00%> (-0.27%) ⬇️
scapy/layers/ldap.py 67.98% <100.00%> (+2.75%) ⬆️
scapy/asn1fields.py 83.26% <85.71%> (-0.58%) ⬇️
scapy/layers/kerberos.py 54.72% <84.78%> (+0.34%) ⬆️

... and 7 files with indirect coverage changes

@gpotter2 gpotter2 changed the title ASN.1: minor cleanup + LDAP bug fixes ASN.1: minor cleanup + LDAP/KRB bug fixes Mar 2, 2024
@gpotter2 gpotter2 force-pushed the ldap-bugfixes branch 2 times, most recently from 003c47f to cd92c32 Compare March 2, 2024 22:05
@gpotter2 gpotter2 added this to the 2.6.0 milestone Mar 2, 2024
@gpotter2 gpotter2 added bug cleanup Performs some code clean-up labels Mar 2, 2024
@gpotter2 gpotter2 merged commit df6eabe into secdev:master Mar 4, 2024
@gpotter2 gpotter2 deleted the ldap-bugfixes branch March 4, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug cleanup Performs some code clean-up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ASN.1 BER ID encoding broken by PR #3693 (Kerberos: documentation + various fixes + demo)

1 participant