ci: skip OpenLDAP tests on Packit#4540
Merged
gpotter2 merged 1 commit intosecdev:masterfrom Sep 28, 2024
Merged
Conversation
until I figure out whether it's possible to set up slapd there by analogy with what the scapy action on GitHub does. It's a follow-up to secdev#4539.
Contributor
Author
|
Looks like the OpenLDAP tests failed: https://github.com/secdev/scapy/actions/runs/11085252379/job/30801458305?pr=4540. It's not related to this PR though. ###(001)=[failed] (OpenLDAP) connect to server, bind, search
>>> cli = LDAP_Client()
>>> cli.connect("127.0.0.1")
┃ Connecting to 127.0.0.1 on port 389...
└ Connected from ('127.0.0.1', 53032)
>>> cli.bind(LDAP_BIND_MECHS.SIMPLE, simple_username="cn=admin,dc=scapy,dc=net", simple_password="Bonjour1")
>> LDAP_BindRequest
<< LDAP_BindResponse
SIMPLE bind succeeded !
>>> res = cli.search("dc=scapy,dc=net", "(&(givenName=Another)(sn=Test))", scope=2)
>> LDAP_SearchRequest
<< LDAP_SearchResponseEntry
###[ LDAP ]###
messageID = 0x2 <ASN1_INTEGER[2]>
\protocolOp\
|###[ LDAP_SearchResponseEntry ]###
| objectName= <ASN1_STRING[b'uid=another,ou=People,dc=scapy,dc=net']>
| \attributes\
| |###[ LDAP_SearchResponseEntryAttribute ]###
| | type = <ASN1_STRING[b'objectClass']>
| | \values \
| | |###[ LDAP_SearchResponseEntryAttributeValue ]###
| | | value = <ASN1_STRING[b'top']>
| | |###[ LDAP_SearchResponseEntryAttributeValue ]###
| | | value = <ASN1_STRING[b'person']>
| | |###[ LDAP_SearchResponseEntryAttributeValue ]###
| | | value = <ASN1_STRING[b'inetOrgPerson']>
| |###[ LDAP_SearchResponseEntryAttribute ]###
| | type = <ASN1_STRING[b'cn']>
| | \values \
| | |###[ LDAP_SearchResponseEntryAttributeValue ]###
| | | value = <ASN1_STRING[b'Another Test']>
| |###[ LDAP_SearchResponseEntryAttribute ]###
| | type = <ASN1_STRING[b'uid']>
| | \values \
| | |###[ LDAP_SearchResponseEntryAttributeValue ]###
| | | value = <ASN1_STRING[b'another']>
| |###[ LDAP_SearchResponseEntryAttribute ]###
| | type = <ASN1_STRING[b'sn']>
| | \values \
| | |###[ LDAP_SearchResponseEntryAttributeValue ]###
| | | value = <ASN1_STRING[b'Test']>
| |###[ LDAP_SearchResponseEntryAttribute ]###
| | type = <ASN1_STRING[b'givenName']>
| | \values \
| | |###[ LDAP_SearchResponseEntryAttributeValue ]###
| | | value = <ASN1_STRING[b'Another']>
| |###[ LDAP_SearchResponseEntryAttribute ]###
| | type = <ASN1_STRING[b'userPassword']>
| | \values \
| | |###[ LDAP_SearchResponseEntryAttributeValue ]###
| | | value = <ASN1_STRING[b'testing']>
Controls = None
Traceback (most recent call last):
File "<input>", line 2, in <module>
File "/home/runner/work/scapy/scapy/scapy/layers/ldap.py", line 2085, in search
raise TimeoutError("Search timed out.")
TimeoutError: Search timed out. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4540 +/- ##
==========================================
- Coverage 81.62% 81.51% -0.11%
==========================================
Files 356 356
Lines 85533 85533
==========================================
- Hits 69814 69723 -91
- Misses 15719 15810 +91 |
Member
Thanks for reporting that. In the mean time, thanks for the PR ! |
gpotter2
approved these changes
Sep 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
until I figure out whether it's possible to set up slapd there by analogy with what the scapy action on GitHub does.
It's a follow-up to #4539.