Skip to content

Conversation

@arjunbhat1
Copy link
Contributor

Fixes #3853

Scapy's TLS layer corrupts packet data in some cases during dissection of TLS records containing invalid extension fields (extlen != len(ext)).

A corresponding unit test has been added as well.

@codecov
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (c38a5de) to head (6cc0246).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4554   +/-   ##
=======================================
  Coverage   81.61%   81.62%           
=======================================
  Files         356      356           
  Lines       85540    85542    +2     
=======================================
+ Hits        69816    69824    +8     
+ Misses      15724    15718    -6     
Files with missing lines Coverage Δ
scapy/layers/tls/extensions.py 83.90% <100.00%> (+0.10%) ⬆️

... and 7 files with indirect coverage changes

Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR !

@gpotter2 gpotter2 merged commit 4a66706 into secdev:master Oct 14, 2024
@arjunbhat1 arjunbhat1 deleted the fix-tls-pkt-corruption branch October 15, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TLS class modifies packets with invalid extensions data

2 participants