Skip to content

Conversation

@Lastpixl
Copy link
Contributor

Prevents the following stacktrace:

dns_resolve("_kerberos._tcp.dc._msdcs.example.com", qtype="SRV")
File scapy/layers/dns.py:1453, in dns_resolve(qname, qtype, raw, tcp, verbose, timeout, **kwargs)
TypeError: scapy.layers.dns.dns_resolve() got multiple values for keyword argument 'timeout'

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.88%. Comparing base (4317859) to head (5ad97de).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4847      +/-   ##
==========================================
- Coverage   80.88%   80.88%   -0.01%     
==========================================
  Files         368      368              
  Lines       90340    90340              
==========================================
- Hits        73070    73069       -1     
- Misses      17270    17271       +1     
Files with missing lines Coverage Δ
scapy/layers/dns.py 83.61% <100.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

guedou
guedou previously approved these changes Sep 30, 2025
@guedou guedou enabled auto-merge (squash) September 30, 2025 18:21
auto-merge was automatically disabled October 1, 2025 21:40

Head branch was pushed to by a user without write access

@Lastpixl Lastpixl force-pushed the remove-duplicate-argument branch from 9e5ded3 to 5ad97de Compare October 1, 2025 21:40
@p-l- p-l- merged commit 90c5ff4 into secdev:master Oct 3, 2025
24 of 45 checks passed
p-l- pushed a commit that referenced this pull request Oct 5, 2025
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants