Skip to content

Conversation

@gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Oct 3, 2025

2.6.1:

>>> dns_resolve("google.com")
[<DNSRR  rrname=b'google.com.' type=A cacheflush=0 rclass=IN ttl=100 rdata=142.250.75.238 |>]

master (post #4847):

>>> dns_resolve("google.com")
Begin emission

Finished sending 1 packets

Received 1 packets, got 1 answers, remaining 0 packets
[<DNSRR  rrname=b'google.com.' type=A cacheflush=0 rclass=IN ttl=100 rdata=142.250.75.238 |>]

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.88%. Comparing base (6ed82a2) to head (9aff3e2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4852      +/-   ##
==========================================
- Coverage   80.88%   80.88%   -0.01%     
==========================================
  Files         368      368              
  Lines       90340    90340              
==========================================
- Hits        73074    73072       -2     
- Misses      17266    17268       +2     
Files with missing lines Coverage Δ
scapy/layers/dns.py 83.61% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 added the bug label Oct 4, 2025
@p-l-
Copy link
Member

p-l- commented Oct 5, 2025

I'm not sure to understand: wouldn't it be better to set verbose to 0 by default? With this, there is no way to set the verbosity of sr(), right?

@gpotter2
Copy link
Member Author

gpotter2 commented Oct 5, 2025

The verbose parameter in dns_resolve has the following description:

    :param verbose: show verbose errors

Does that answer your question?

@p-l- p-l- merged commit 12a3752 into secdev:master Oct 5, 2025
24 checks passed
@gpotter2 gpotter2 deleted the dns-regression-fix branch October 5, 2025 10:42
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants