Skip to content

WinSSP: support Encryption, fix DCE/RPC SMB IO#4978

Merged
gpotter2 merged 7 commits into
secdev:masterfrom
gpotter2:utf
Apr 23, 2026
Merged

WinSSP: support Encryption, fix DCE/RPC SMB IO#4978
gpotter2 merged 7 commits into
secdev:masterfrom
gpotter2:utf

Conversation

@gpotter2
Copy link
Copy Markdown
Member

@gpotter2 gpotter2 commented Apr 22, 2026

  • improve support of NCACN_NP, most notably send() did not work (sr1 did)
  • add support for Encryption/Decryption/Signatures and channel binding in WinSSP
  • minor logging changes

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 44.64286% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.22%. Comparing base (cdc199a) to head (f841c62).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/arch/windows/sspi.py 45.31% 70 Missing ⚠️
scapy/layers/ldap.py 10.00% 9 Missing ⚠️
scapy/layers/spnego.py 42.85% 4 Missing ⚠️
scapy/utils.py 0.00% 3 Missing ⚠️
scapy/layers/msrpce/rpcclient.py 60.00% 2 Missing ⚠️
scapy/modules/ldaphero.py 0.00% 2 Missing ⚠️
scapy/tools/UTscapy.py 0.00% 2 Missing ⚠️
scapy/layers/smbclient.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4978      +/-   ##
==========================================
- Coverage   80.27%   80.22%   -0.05%     
==========================================
  Files         382      382              
  Lines       93996    94124     +128     
==========================================
+ Hits        75452    75510      +58     
- Misses      18544    18614      +70     
Files with missing lines Coverage Δ
scapy/layers/dcerpc.py 90.66% <100.00%> (+0.01%) ⬆️
scapy/layers/windows/erref.py 100.00% <ø> (ø)
scapy/sendrecv.py 86.51% <100.00%> (+0.01%) ⬆️
scapy/layers/smbclient.py 75.21% <80.00%> (-0.07%) ⬇️
scapy/layers/msrpce/rpcclient.py 57.82% <60.00%> (-0.11%) ⬇️
scapy/modules/ldaphero.py 0.00% <0.00%> (ø)
scapy/tools/UTscapy.py 65.37% <0.00%> (ø)
scapy/utils.py 72.33% <0.00%> (-0.08%) ⬇️
scapy/layers/spnego.py 83.10% <42.85%> (-0.70%) ⬇️
scapy/layers/ldap.py 66.82% <10.00%> (-0.21%) ⬇️
... and 1 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 force-pushed the utf branch 2 times, most recently from 6e30c93 to f841c62 Compare April 23, 2026 13:01
@gpotter2 gpotter2 merged commit 08aafdf into secdev:master Apr 23, 2026
24 checks passed
@gpotter2 gpotter2 deleted the utf branch April 23, 2026 13:10
Copilot AI pushed a commit to BenGardiner/scapy that referenced this pull request Apr 27, 2026
* WinSSP: support Encryption, fix DCE/RPC SMB IO

* Add use_winssp boolean

* Show output of test when it timeout

* Flake8 for ldaphero

* Fix doc

* Add debug log for HTTP_Server

* WinSSP: support channel bindings
Co-authored-by: BenGardiner <243321+BenGardiner@users.noreply.github.com>
Copilot AI pushed a commit to polybassa/scapy-1 that referenced this pull request May 25, 2026
* WinSSP: support Encryption, fix DCE/RPC SMB IO

* Add use_winssp boolean

* Show output of test when it timeout

* Flake8 for ldaphero

* Fix doc

* Add debug log for HTTP_Server

* WinSSP: support channel bindings
Co-authored-by: polybassa <1676055+polybassa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant