Cache clears on every startup if new cache location is invalid

[Hecklezz]

Environment

Second Life Release 7.2.3.19118091373 (64bit)

Rest of environment-

Release Notes

CPU: Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (3600.01 MHz)
Memory: 16302 MB
OS Version: Microsoft Windows 10 64-bit (Build 19045.6456)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: NVIDIA GeForce RTX 2080/PCIe/SSE2

Windows Graphics Driver Version: 32.0.15.8115
OpenGL Version: 4.6.0 NVIDIA 581.15

Window size: 1920x1091
Font Size Adjustment: 96pt
UI Scaling: 1
Draw distance: 512m
Bandwidth: 3000kbit/s
LOD factor: 4
Render quality: 5
Texture memory: 8192MB
Disk cache: Max size 2150.4 MB (78.2% used)

J2C Decoder Version: KDU v8.4.1
Audio Driver Version: OpenAL, version 1.1 ALSOFT 1.24.2 / OpenAL Community / OpenAL Soft: OpenAL Soft
Dullahan: 1.24.0.202510081738
CEF: 139.0.40+g465474a+chromium-139.0.7258.139
Chromium: 139.0.7258.139
LibVLC Version: 3.0.21
Voice Server Version:

November 14 2025 08:12:12

Description

PR with fix: #5003

If the new cache location is set and that location becomes invalid (such as disconnecting the drive it was set to), the cache location falls back to the default location as it should. However, the NewCacheLocation setting stays the old invalid location which creates an issue where every single time the viewer is launched, it compares the now default cache location to the new invalid cache location, realises they don't match and clears the cache. Then because the NewCacheLocation is still invalid, the CacheLocation stays the default and once again the next time you open the viewer, the same check is ran and the cache is cleared once more.

Essentially resulting in the viewer never having a cache which is definitely undesirable. This also causes another issue observed by a Firestorm member. Their inventory was quite large and because they had no working cache, their inventory needed to be re-fetched every time. The inventory fetching process took so long that the Favorites tab was completely broken and items they had favorited sometimes would or wouldn't appear, or items they previously had deleted would reappear in the Favorites tab but not starred and highlighted as favorites as they should be in that tab. After fixing this cache issue, that issue completely went away.

Reproduction steps

1. Set NewCacheLocation to an invalid file path (Either in debug settings or set it to another drive first, then disconnecting that drive)
2. Relaunch the viewer and observe it clear the cache
3. Relaunch the viewer and observe it clear the cache again and do so on every single launch

---

This repo is using Opire - what does it mean? 👇

💵 Everyone can add rewards for this issue commenting /reward 100 (replace 100 with the amount).
🕵️‍♂️ If someone starts working on this issue to earn the rewards, they can comment /try to let everyone know!
🙌 And when they open the PR, they can comment /claim #5002 either in the PR description or in a PR's comment.

🪙 Also, everyone can tip any user commenting /tip 20 @Hecklezz (replace 20 with the amount, and @Hecklezz with the user to tip).

📖 If you want to learn more, check out our documentation.