[#5002] Fix the cache from being cleared every launch if NewCacheLocation is invalid #5003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…invalid Signed-off-by: Hecklezz <tj8@live.com.au>
Hecklezz
force-pushed
the
fix/invalid_cache_location_clearing
branch
from
a856f83 to
57c24c6
Compare
akleshchev
approved these changes
Nov 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5002
Fixes the above issue by simply setting NewCacheLocation to empty, the same as CacheLocation, if the cache location was unable to be set which was causing the viewer to clear its cache every time it was ran because CacheLocation != NewCacheLocation as NewCacheLocation was never reset.