#3670 Add a sortable status column to the list of gestures #4912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a visual indicator column to the gesture list UI to show which gestures are currently active using a checkmark icon, improving user experience by making gesture state immediately visible.
- Added a new "active" column with checkmark icons to display gesture active state
- Implemented icon sizing functionality in LLScrollListIcon to support custom icon dimensions
- Updated column indexing throughout the gesture list to accommodate the new first column
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| floater_gesture.xml | Added new "active" icon column and adjusted "name" column width to accommodate it |
| llfloatergesture.cpp | Shifted all column indices by 1 and added logic to populate the active column with checkmark icons |
| llscrolllistcell.h | Added setIconSize method and mIconSize member variable to LLScrollListIcon |
| llscrolllistcell.cpp | Implemented icon size functionality with updated draw logic and width calculation |
Comments suppressed due to low confidence (1)
indra/newview/llfloatergesture.cpp:315
- Using a static local variable for font_style causes the previous call's value to persist across invocations. If a playing gesture sets it to 'BOLD', subsequent non-playing gestures will incorrectly inherit 'BOLD' style. Change this to a non-static local variable.
static std::string font_style = "NORMAL";
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marchcat
approved these changes
Oct 30, 2025
maxim-productengine
approved these changes
Oct 30, 2025
akleshchev
force-pushed
the
andreyk/viewer_3670
branch
from
b82b651 to
ead7825
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sortable colum that display checkmark for active gestures.