Add notecard name to tempfile created for editing notecard externally - #5291
Merged
marchcat merged 2 commits intoJan 20, 2026
Conversation
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
marchcat
approved these changes
Jan 19, 2026
marchcat
left a comment
marchcat
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution!
akleshchev
approved these changes
Jan 19, 2026
Contributor
|
@marchcat are there any editor tickets this can be attached to in lua branch or does it need a new one? |
Contributor
|
Created #5297 for tracking. |
Rider-Linden
approved these changes
Jan 20, 2026
Rider-Linden
left a comment
Rider-Linden
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thank you!
Just the one C++ism and I'm not sure where what the viewer standard is, so not a blocker.
| } | ||
|
|
||
| std::string LLPreviewNotecard::getTmpFileName() | ||
| std::string LLPreviewNotecard::getTmpFileName(const std::string& note_name) const |
Contributor
There was a problem hiding this comment.
I'm not sure if this applies to viewer development, but, on the server side, we've been passing std::string_view instead of const std::string &...
Contributor
There was a problem hiding this comment.
We are still using const references in most places.
Contributor
|
There appears to be a conflict that prevents a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the name of the notecard to the temp file created when editing a notecard externally, matching the implementation for external script editing, and allowing better editing of notecards with the
sl-vscode-pluginChecklist
Please ensure the following before requesting review:
Additional Notes
I reused the logic from
llpreviewscriptfor stripping special characters, and for where the viewer tries to create the file with the name of the asset, then if that fails it attempts again without the name, (usually due to path length constraints on windows).