Skip to content

#5084 Improve watchdog's behavior - #5502

Merged
akleshchev merged 3 commits into
release/2026.02from
andreyk/viewer_5084_nicerhandling
Mar 9, 2026
Merged

#5084 Improve watchdog's behavior#5502
akleshchev merged 3 commits into
release/2026.02from
andreyk/viewer_5084_nicerhandling

Conversation

@akleshchev

@akleshchev akleshchev commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Draft

  • On windows watchdog will report the freeze to bugsplat than just stop observing (unless thread wakes up), viewer will keep 'running'. If reporting isn't avaliable, it will fallback to crashing (for ease of testing).
  • On mac watchdog will not gently go into the night, but instead will show a notification to user and will attempt to logout.
  • On both platforms watchdog will create a marker. So that if viewer gets closed forcefully, next launch will know if problem was caught by watchdog and will be reported to statistics

To be resolved in separate PRs:

  • Watchdog triggering on modal OS level notifications
  • Find if Mac can report without callstack (dows not support runtime reporting with callstack)
  • Decide how to handle mac vs windows difference. We probably want to report at 20s without crashing, then crash at 5m or something similar.

@akleshchev
akleshchev marked this pull request as draft March 6, 2026 01:46
@akleshchev
akleshchev force-pushed the andreyk/viewer_5084_nicerhandling branch 3 times, most recently from fc5a15d to e374cb6 Compare March 8, 2026 21:45
@akleshchev
akleshchev marked this pull request as ready for review March 8, 2026 21:45
@akleshchev
akleshchev force-pushed the andreyk/viewer_5084_nicerhandling branch from e374cb6 to b2f4998 Compare March 8, 2026 21:48
@akleshchev

akleshchev commented Mar 8, 2026

Copy link
Copy Markdown
Contributor Author

Getting to something I'm happy with. Tested and watchdog created a marker, then properly set 'froze' state for statistics report.

@akleshchev
akleshchev force-pushed the andreyk/viewer_5084_nicerhandling branch 3 times, most recently from 96cb03d to 5238758 Compare March 9, 2026 14:12
@akleshchev
akleshchev force-pushed the andreyk/viewer_5084_nicerhandling branch from 5238758 to cef6d06 Compare March 9, 2026 16:16
@github-actions github-actions Bot added the cmake label Mar 9, 2026
@akleshchev
akleshchev changed the base branch from develop to release/2026.02 March 9, 2026 16:17
@akleshchev

akleshchev commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

Rebased to 2026.02

@akleshchev
akleshchev merged commit fdd7e88 into release/2026.02 Mar 9, 2026
16 checks passed
@akleshchev
akleshchev deleted the andreyk/viewer_5084_nicerhandling branch March 9, 2026 21:18
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marchcat marchcat marchcat approved these changes
@maxim-productengine maxim-productengine Awaiting requested review from maxim-productengine

Assignees

No one assigned

Labels

c/cpp cmake llcommon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akleshchev @marchcat