#2975 Fix scale calculation - #5535
Merged
Merged
Conversation
akleshchev
force-pushed
the
andreyk/viewer_2975_rotate_scale
branch
from
March 12, 2026 23:06
6aade1e to
26f6f28
Compare
Needs to account for rotation
akleshchev
force-pushed
the
andreyk/viewer_2975_rotate_scale
branch
from
March 13, 2026 17:03
26f6f28 to
8b37b13
Compare
akleshchev
force-pushed
the
andreyk/viewer_2975_rotate_scale
branch
from
March 13, 2026 18:14
8b37b13 to
ad52be3
Compare
maxim-productengine
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made scale account for rotation.
Unfortunately pbr scale and legacy scale are different enough that there might be no full tranformation from one to another, but it looks like this should cover 45 and 90 degree cases decently enough.