Skip to content

#5628 Update taskbar's link to point to velopack - #5630

Merged
akleshchev merged 1 commit into
release/2026.02from
andreyk/5346_dupplicate
Apr 13, 2026
Merged

#5628 Update taskbar's link to point to velopack#5630
akleshchev merged 1 commit into
release/2026.02from
andreyk/5346_dupplicate

Conversation

@akleshchev

@akleshchev akleshchev commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Try updating user created taskbar link to point at a new install.

If icon is present, try to update it to point at current release. If update failed, try to remove it and then try to recreate.

@akleshchev
akleshchev marked this pull request as draft April 9, 2026 18:24
@akleshchev
akleshchev requested a review from Copilot April 9, 2026 18:24
@github-actions github-actions Bot added the c/cpp label Apr 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Windows Velopack/NSIS migration behavior to refresh a user’s pinned taskbar shortcut so it points at the newly installed executable.

Changes:

  • Clarifies the expected desktop shortcut path in clear_nsis_links().
  • Adds logic intended to delete and recreate a user-specific pinned taskbar .lnk during NSIS cleanup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread indra/newview/llvelopack.cpp Outdated
@akleshchev
akleshchev force-pushed the andreyk/5346_dupplicate branch from c03054e to f3811bd Compare April 9, 2026 19:34
@akleshchev
akleshchev requested a review from Copilot April 9, 2026 19:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread indra/newview/llvelopack.cpp Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread indra/newview/llvelopack.cpp Outdated
Comment thread indra/newview/llvelopack.cpp Outdated
Comment thread indra/newview/llvelopack.cpp Outdated
Comment thread indra/newview/llvelopack.cpp
Comment thread indra/newview/llvelopack.cpp Outdated
@akleshchev
akleshchev force-pushed the andreyk/5346_dupplicate branch 2 times, most recently from 63f26d3 to 7572aa3 Compare April 9, 2026 21:07
@akleshchev
akleshchev requested a review from Copilot April 9, 2026 21:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread indra/newview/llvelopack.cpp Outdated
Comment thread indra/newview/llvelopack.cpp Outdated
Comment thread indra/newview/llvelopack.cpp
Comment thread indra/newview/llvelopack.cpp Outdated
@akleshchev
akleshchev force-pushed the andreyk/5346_dupplicate branch 2 times, most recently from ad9008f to f130dd1 Compare April 9, 2026 21:30
@akleshchev
akleshchev requested a review from Copilot April 9, 2026 21:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread indra/newview/llvelopack.cpp
Comment thread indra/newview/llvelopack.cpp Outdated
Comment thread indra/newview/llvelopack.cpp Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread indra/newview/llvelopack.cpp Outdated
Comment thread indra/newview/llvelopack.cpp

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread indra/newview/llvelopack.cpp
Comment thread indra/newview/llvelopack.cpp
Comment thread indra/newview/llvelopack.cpp Outdated
Comment thread indra/newview/llvelopack.cpp Outdated
@akleshchev
akleshchev force-pushed the andreyk/5346_dupplicate branch from 9cde794 to 93d3346 Compare April 9, 2026 22:29
@akleshchev
akleshchev force-pushed the andreyk/5346_dupplicate branch from 93d3346 to fa64c34 Compare April 10, 2026 00:11
@akleshchev
akleshchev marked this pull request as ready for review April 10, 2026 00:12
@akleshchev
akleshchev requested a review from Geenz April 10, 2026 16:17
@akleshchev
akleshchev merged commit 49790ad into release/2026.02 Apr 13, 2026
13 checks passed
@akleshchev
akleshchev deleted the andreyk/5346_dupplicate branch April 13, 2026 21:35
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update taskbar's link to point to velopack viewer (was: SLVersionChecker.py barfs on undefined "log")

4 participants