#5809 Add 'mute' based filter for conversation history - #5840
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a "Show muted" filter to the conversation log so blocked agents can be hidden from the call/conversation history, controlled by a new ShowBlockedConvHistory setting and a menu toggle. Also picks up an unrelated focus-handling fix in LLFloaterIMContainer::removeConversationListItem.
Changes:
- Introduces
ShowBlockedConvHistorysaved setting plus a menu item + handlers inLLFloaterConversationLogto toggle it. - Makes
LLConversationLogListanLLMuteListObserver, filters muted participants out ofrebuildList, and refreshes on mute / setting changes; switches comparators toLLCachedControl. - Refines the focus-change condition in
LLFloaterIMContainer::removeConversationListItemto also require an actually selected widget.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| indra/newview/app_settings/settings.xml | Adds the new ShowBlockedConvHistory boolean setting. |
| indra/newview/skins/default/xui/en/menu_conversation_log_view.xml | Adds the "Show muted" menu item bound to the show_blocked action. |
| indra/newview/llfloaterconversationlog.cpp | Wires the show_blocked action/check to ShowBlockedConvHistory. |
| indra/newview/llconversationloglist.h | Inherits LLMuteListObserver, adds mute callbacks and a control signal connection. |
| indra/newview/llconversationloglist.cpp | Registers as mute observer, filters muted entries in rebuildList, marks dirty on relevant mute/setting changes; switches comparators to LLCachedControl. |
| indra/newview/llfloaterimcontainer.cpp | Only steals focus when a widget was actually selected. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Don't add blocked conversations - Menus and global setting to control this mechanics - Refresh on changes Decided just not to add blocked conversation to the list, an alternate way is to alter visibility logic or filter logic
akleshchev
force-pushed
the
andreyk/viewer_5809
branch
from
May 19, 2026 21:29
ab0b5f1 to
a1ba645
Compare
maxim-productengine
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decided just not to add blocked conversation to the list, an alternate way is to alter visibility logic or filter logic.