#5611 Skip default windows' gpu drivers - #5909
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Windows DXGI adapter enumeration in LLWindowWin32::requestHighPerformanceGPU() to ignore the “Microsoft Basic Render Driver” placeholder adapter when selecting a preferred/high-performance GPU, aligning with the “hold dedicated gpu context” follow-up behavior.
Changes:
- Add an explicit skip for “Microsoft Basic Render Driver” during adapter selection.
- Emit a warning log when that placeholder adapter is encountered (instead of treating it as a candidate).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/viewer_5611_3
branch
from
June 9, 2026 18:36
354b16a to
4e5cc2f
Compare
akleshchev
force-pushed
the
andreyk/viewer_5611_3
branch
from
June 9, 2026 18:37
4e5cc2f to
828363b
Compare
akleshchev
changed the title
maxim-productengine
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for new 'hold dedicated gpu context' as a way to selct high performance gpu.
Ignore 'placeholder' driver, it likely isn't going to work.