#3672 Fix shader compilation error - #5910
Merged
Merged
Conversation
Geenz
approved these changes
Jun 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a GLSL shader compilation issue in CASF.glsl (deferred shader path) that affects Intel GPUs by ensuring a sign-bit mask constant is treated as an unsigned integer.
Changes:
- Add the
usuffix to0x80000000in the[FIS] FLOAT INTEGER SORTABLEhelper functions so the constant is unambiguouslyuintand avoids literal overflow / type-mismatch on stricter GLSL compilers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CASF.glsl's failure to compile on intel gpus.