#6061 Fix wrapper exe having spaces - #6065
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Windows Velopack packaging metadata to avoid spaces in the --packTitle value, aiming to prevent generation of wrapper-related executables/links that include spaces after a Velopack behavior change.
Changes:
- Set Velopack
pack_titleto a no-spaces app name (app_name_oneword()) for Windows packaging. - Keep the rest of the Windows Velopack pack arguments unchanged (pack id/version/dir/main exe/excludes/shortcuts).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/viewer_6061
branch
from
July 29, 2026 18:43
42810b2 to
088ffdc
Compare
Contributor
Author
|
Checked the final pacakge, no spaces in the wrapper, spaces in the link, as it should be. |
maxim-productengine
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
26.3 packs with the same arguments as 26.2, yet wrapper sudenly started having spaces, which breaks some exising links.
Looks like velopack was updated and meaning of
--packTitlechanged. We manage links and uninstall record on our own, so just change packTitle.P.S. This is partially a test to see if it actually works, packTitle might affect something I'm not aware of.