Skip to content

p#682 Improve logging for system events and session - #6086

Merged
akleshchev merged 6 commits into
release/26.3from
andreyk/p682_logging
Aug 4, 2026
Merged

p#682 Improve logging for system events and session#6086
akleshchev merged 6 commits into
release/26.3from
andreyk/p682_logging

Conversation

@akleshchev

Copy link
Copy Markdown
Contributor

The important bits are watchdog specific and SetThreadDescription

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances runtime observability for Windows/system events and session behavior by adding more watchdog pings/logging around Win32 message handling, passing device-change context through the window callback API, and improving debugging ergonomics (thread naming).

Changes:

  • Extend handleDeviceChange callbacks to include a change_type string, and log device/display changes in the viewer.
  • Add additional watchdog “ping” points around key Win32 window messages and introduce LLWatchdogTimeout::started().
  • Adjust second-instance voice behavior to disable voice only for the current session (with additional debug logging).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
indra/newview/llviewerwindow.h Updates device-change callback signature to include change_type.
indra/newview/llviewerwindow.cpp Logs device/display change events and adapts to new callback signature.
indra/newview/llappviewer.cpp Tweaks second-instance voice disabling logic and adds debug logging.
indra/llwindow/llwindowwin32.cpp Adds watchdog pings for Win32 messages, expands event logging, and sets a thread description.
indra/llwindow/llwindowcallbacks.h Updates callback interface for device-change change_type.
indra/llwindow/llwindowcallbacks.cpp Updates default callback implementation signature for device-change change_type.
indra/llui/llfloater.cpp Adds a TODO note about per-frame visibility control overhead.
indra/llcommon/llwatchdog.h Adds started() to the watchdog interface and timeout implementation.
indra/llcommon/llwatchdog.cpp Implements LLWatchdogTimeout::started().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread indra/llwindow/llwindowwin32.cpp Outdated
Comment thread indra/llwindow/llwindowwin32.cpp Outdated
Comment thread indra/llwindow/llwindowwin32.cpp Outdated
Comment thread indra/llwindow/llwindowwin32.cpp Outdated
Comment thread indra/llwindow/llwindowwin32.cpp
Comment thread indra/llwindow/llwindowcallbacks.h
Comment thread indra/newview/llappviewer.cpp
akleshchev and others added 4 commits August 4, 2026 18:12
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@akleshchev
akleshchev merged commit cef8c85 into release/26.3 Aug 4, 2026
7 checks passed
@akleshchev
akleshchev deleted the andreyk/p682_logging branch August 4, 2026 16:39
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants