p#682 Improve logging for system events and session - #6086
Merged
Conversation
akleshchev
force-pushed
the
andreyk/p682_logging
branch
from
August 4, 2026 14:55
4fad9af to
47e16f9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances runtime observability for Windows/system events and session behavior by adding more watchdog pings/logging around Win32 message handling, passing device-change context through the window callback API, and improving debugging ergonomics (thread naming).
Changes:
- Extend
handleDeviceChangecallbacks to include achange_typestring, and log device/display changes in the viewer. - Add additional watchdog “ping” points around key Win32 window messages and introduce
LLWatchdogTimeout::started(). - Adjust second-instance voice behavior to disable voice only for the current session (with additional debug logging).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| indra/newview/llviewerwindow.h | Updates device-change callback signature to include change_type. |
| indra/newview/llviewerwindow.cpp | Logs device/display change events and adapts to new callback signature. |
| indra/newview/llappviewer.cpp | Tweaks second-instance voice disabling logic and adds debug logging. |
| indra/llwindow/llwindowwin32.cpp | Adds watchdog pings for Win32 messages, expands event logging, and sets a thread description. |
| indra/llwindow/llwindowcallbacks.h | Updates callback interface for device-change change_type. |
| indra/llwindow/llwindowcallbacks.cpp | Updates default callback implementation signature for device-change change_type. |
| indra/llui/llfloater.cpp | Adds a TODO note about per-frame visibility control overhead. |
| indra/llcommon/llwatchdog.h | Adds started() to the watchdog interface and timeout implementation. |
| indra/llcommon/llwatchdog.cpp | Implements LLWatchdogTimeout::started(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
marchcat
approved these changes
Aug 4, 2026
maxim-productengine
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The important bits are watchdog specific and SetThreadDescription