#6117 Guard against stale nearby chat toast handles - #6120
Merged
Conversation
akleshchev
approved these changes
Aug 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the nearby chat toast pooling logic to prevent crashes caused by stale LLHandle<LLToast> entries whose underlying LLToast objects have already been destroyed.
Changes:
- Prunes destroyed toast handles from the pool when updating toast lifetime/fade settings.
- Introduces
getToastFromPool()to safely retrieve a live toast (discarding dead handles). - Updates
addChat()to replenish the pool and avoid dereferencing a dead toast handle.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent nearby chat crashes.