#6153 Make hardware test more robust - #6175
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent GPU hardware benchmarking from freezing/crashing the main viewer by running the benchmark in a dedicated subprocess on Windows and returning the result via stdout.
Changes:
- Add Windows subprocess execution path for the GPU memory bandwidth benchmark and a
--gpubenchmarkmode to run-and-exit. - Teach startup/init to behave differently in benchmark subprocess mode (skip mutex, console, splash, marker processing, extra dump logs).
- Document and allow the new command-line flag through the command-line option system.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| indra/newview/llfeaturemanager.cpp | Runs the GPU benchmark in an isolated subprocess and returns the parsed result to the main process. |
| indra/newview/llcommandlineparser.cpp | Adds gpubenchmark to the set of permitted unmapped command-line switches. |
| indra/newview/llappviewerwin32.cpp | Detects --gpubenchmark early and adjusts startup behavior (mutex/console) for subprocess mode. |
| indra/newview/llappviewer.cpp | Skips splash/marker/log spam behaviors when running in GPU benchmark subprocess mode. |
| indra/newview/app_settings/cmd_line.xml | Documents the new --gpubenchmark command-line switch. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
akleshchev
force-pushed
the
andreyk/viewer_6153
branch
from
August 24, 2026 17:39
4f87afa to
faeb8d1
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Suppressed comments (1)
indra/newview/llappviewer.cpp:2390
- Typo in comment: "wa" → "was".
// Originally this wa used to store states, but I don't think it's practical with bugsplat attributes.
akleshchev
marked this pull request as ready for review
August 24, 2026 19:29
maxim-productengine
approved these changes
Aug 24, 2026
marchcat
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harware test can freeze and crash, taking whole viewer with it. Move test to a process to make sure viewer doesn't get affected.