Skip to content

#6109 StopRecording() crash - #6197

Merged
akleshchev merged 1 commit into
developfrom
andreyk/viewer_6109
Aug 25, 2026
Merged

#6109 StopRecording() crash#6197
akleshchev merged 1 commit into
developfrom
andreyk/viewer_6109

Conversation

@akleshchev

@akleshchev akleshchev commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

updateDevices should always happen from a worker thread.

Scenario: plug in a headset while mic is toggled on

@github-actions github-actions Bot added the c/cpp label Aug 25, 2026
@akleshchev akleshchev linked an issue Aug 25, 2026 that may be closed by this pull request
BugSplat Report: libllwebrtc.dylib!webrtc::webrtc_checks_impl::WriteFatalLog(std::__1::basic_string_view<char, std::__1::char_traits<char> >)(88) #6109
Open
roxanneskelly
roxanneskelly approved these changes Aug 25, 2026
View reviewed changes

@roxanneskelly roxanneskelly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akleshchev
akleshchev merged commit 4ef9f8f into develop Aug 25, 2026
15 checks passed
@akleshchev
akleshchev deleted the andreyk/viewer_6109 branch August 25, 2026 20:05
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roxanneskelly roxanneskelly roxanneskelly approved these changes

Assignees

No one assigned

Labels

c/cpp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BugSplat Report: libllwebrtc.dylib!webrtc::webrtc_checks_impl::WriteFatalLog(std::__1::basic_string_view<char, std::__1::char_traits<char> >)(88)

2 participants

@akleshchev @roxanneskelly