Fix scale startup issues on MacOS - #6215
Merged
Merged
Conversation
akleshchev
force-pushed
the
andreyk/viewer_p700_3
branch
from
August 28, 2026 18:12
d014b91 to
e5930d3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix macOS startup UI scaling issues by ensuring the viewer marks its resolution/scale state as “dirty” even when the view attaches to a window without an immediate size change, making the eventual reshape/scale computation happen reliably.
Changes:
- Add a new window callback (
handleRequestResolutionUpdate) and a macOS bridge (callRequestResolutionUpdate) to request a deferred resolution/scale update. - Update macOS
viewDidMoveToWindowto request a resolution update when the backing size doesn’t appear to change immediately. - Adjust
LLViewerWindow::checkSettings()to reshape using the live window size queried frommWindow->getSize().
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| indra/newview/llviewerwindow.h | Declares the new handleRequestResolutionUpdate callback on LLViewerWindow. |
| indra/newview/llviewerwindow.cpp | Implements the callback and uses live mWindow->getSize() during deferred reshapes. |
| indra/llwindow/llwindowcallbacks.h | Extends the window callback interface with handleRequestResolutionUpdate. |
| indra/llwindow/llwindowcallbacks.cpp | Adds a default no-op implementation for the new callback. |
| indra/llwindow/llwindowmacosx-objc.h | Exposes callRequestResolutionUpdate() to ObjC/ObjC++ code. |
| indra/llwindow/llwindowmacosx.cpp | Implements callRequestResolutionUpdate() to forward into callbacks. |
| indra/llwindow/llopenglview-objc.mm | Triggers callRequestResolutionUpdate() from viewDidMoveToWindow when appropriate. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
akleshchev
force-pushed
the
andreyk/viewer_p700_3
branch
5 times, most recently
from
August 28, 2026 22:41
537684c to
3b56368
Compare
akleshchev
force-pushed
the
andreyk/viewer_p700_3
branch
from
August 29, 2026 06:33
3b56368 to
166e298
Compare
Contributor
Author
|
QA confirmed that this works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI scale sometimes starts as massive on macOS, which is not visible in logs. What is also missing from logs is handleResize, so I assume that is the cause of the bug. Making viewDidMoveToWindow mark size as dirty even if size didn't change.
Snippet: