p#700 Fix issue with tittle bar on Windows - #6218
Merged
Merged
Conversation
akleshchev
requested review from
maxim-productengine
and
a lite review from Copilot
August 31, 2026 14:22
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts deferred resolution updates to avoid a Windows-specific sizing mismatch where the window title bar could overlap/hide UI elements, and it adds API documentation around LLWindow::getSize() semantics across platforms.
Changes:
- In
LLViewerWindow::checkSettings(), apply the deferred reshape using stored raw dimensions on non-macOS platforms, while keeping a macOS-specificgetSize()path. - Add/adjust header comments describing platform differences for
LLWindow::getSize(LLCoordScreen).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| indra/newview/llviewerwindow.cpp | Changes deferred resolution update flow to avoid using getSize() on non-macOS. |
| indra/llwindow/llwindowwin32.h | Adds documentation describing getSize(LLCoordScreen) behavior on Windows (needs correction). |
| indra/llwindow/llwindowmacosx.h | Adds documentation describing getSize(LLCoordScreen) behavior on macOS (needs correction). |
| indra/llwindow/llwindow.h | Adds cross-platform contract comment for LLWindow::getSize(LLCoordScreen) (needs correction). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
maxim-productengine
approved these changes
Aug 31, 2026
akleshchev
force-pushed
the
andreyk/viewer_p700_4
branch
from
August 31, 2026 14:34
0bf6e20 to
9ec500c
Compare
Hecklezz
reviewed
Aug 31, 2026
| // Deferred resolution update after states have been refreshed. | ||
| #ifdef LL_DARWIN | ||
| // On macOS, LLWindow::getSize(LLCoordScreen) reports the backing view size. | ||
| LLCoordScreen window_size; |
Contributor
There was a problem hiding this comment.
Like I mentioned in the 26.4 PR, wouldn't just changing this line to LLCoordWindow window_size; work for all platforms and not require platform specific checks?
Contributor
Author
There was a problem hiding this comment.
You are right, thank you. I jumped the gun again(
akleshchev
force-pushed
the
andreyk/viewer_p700_4
branch
from
August 31, 2026 14:57
9ec500c to
3fc8e9f
Compare
akleshchev
force-pushed
the
andreyk/viewer_p700_4
branch
from
August 31, 2026 15:32
3fc8e9f to
f972a3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue with tittle bar hiding menu on windows,