Skip to content

fix(backends): materialize cross-state DuckDB relations instead of re… - #421

Merged
oeqqwq merged 2 commits into
mainfrom
ar/fix3
Jul 14, 2026
Merged

fix(backends): materialize cross-state DuckDB relations instead of re…#421
oeqqwq merged 2 commits into
mainfrom
ar/fix3

Conversation

@oeqqwq

@oeqqwq oeqqwq commented Jul 14, 2026

Copy link
Copy Markdown
Member

…jecting them

@oeqqwq
oeqqwq requested a review from a team as a code owner July 14, 2026 02:21
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 14, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables executing SQL queries across different DuckDB connections. Previously, an error was raised if tables belonged to different DuckDB states. Now, query relations from a foreign DuckDB state are materialized as Arrow tables before registration, while same-state queries remain lazy. Comprehensive unit tests have been added to verify this new behavior. I have no feedback to provide as there are no review comments to assess.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

danqi437
danqi437 approved these changes Jul 14, 2026
View reviewed changes

@danqi437 danqi437 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oeqqwq
oeqqwq merged commit c228fb6 into main Jul 14, 2026
11 checks passed
@oeqqwq
oeqqwq deleted the ar/fix3 branch July 14, 2026 02:43
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@danqi437 danqi437 danqi437 approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oeqqwq @danqi437