Skip to content
This repository was archived by the owner on Feb 16, 2023. It is now read-only.

Ask to create an organization on signup#164

Merged
SimonBarendse merged 19 commits intodevelopfrom
feature/signup-org-init
Nov 15, 2019
Merged

Ask to create an organization on signup#164
SimonBarendse merged 19 commits intodevelopfrom
feature/signup-org-init

Conversation

@SimonBarendse
Copy link
Copy Markdown
Member

No description provided.

Comment thread internals/secrethub/signup.go Outdated
Comment thread internals/secrethub/signup.go Outdated
Comment thread internals/secrethub/signup.go Outdated
Comment thread internals/secrethub/signup.go Outdated
Comment thread internals/secrethub/signup.go Outdated
Comment thread internals/secrethub/signup.go Outdated
Comment thread internals/secrethub/signup.go Outdated
Comment thread internals/secrethub/signup.go Outdated
Copy link
Copy Markdown
Member

@mackenbach mackenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit seems to revert the previous commit. I like the changes in the previous commit, in fact I think it's about finished at that point, except for the fact that the last changes are reverted again. Is this intentional?

Please fix it and let me know when it's ready for final review.

@mackenbach
Copy link
Copy Markdown
Member

@SimonBarendse what's blocking this from being fixed and merged?

@SimonBarendse SimonBarendse merged commit c6e76a1 into develop Nov 15, 2019
@SimonBarendse SimonBarendse deleted the feature/signup-org-init branch November 15, 2019 14:34
@SimonBarendse SimonBarendse mentioned this pull request Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants