This repository was archived by the owner on Feb 16, 2023. It is now read-only.
Prompt missing template variables#235
Merged
SimonBarendse merged 20 commits intodevelopfrom Jan 20, 2020
Merged
Conversation
golangcibot
reviewed
Jan 9, 2020
Marton6
commented
Jan 16, 2020
Member
SimonBarendse
left a comment
SimonBarendse
left a comment
There was a problem hiding this comment.
Almost good to go! 🚀
Just one thing about running in a headless environment.
For convenience, here's a summary of what changes through this PR:
- prompt for missing template variables (if
--no-promptis not supplied) - don't error for invalid template variable values if no template file is used
- don't error for template variables being configured (via flags or envvars) if v1 templates are used
Member
SimonBarendse
left a comment
SimonBarendse
left a comment
There was a problem hiding this comment.
Found something to improve in usability.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.