This repository was archived by the owner on Feb 16, 2023. It is now read-only.
Substitute os env vars with the 'secrethub://' prefix#243
Merged
Conversation
Marton6
commented
Feb 14, 2020
Marton6
commented
Feb 14, 2020
jpcoenen
reviewed
Feb 18, 2020
Member
jpcoenen
left a comment
jpcoenen
left a comment
There was a problem hiding this comment.
Looks really nice @Marton6! Really few changes for a such a powerful changeset.
I have a few minor comments, but nothing serious. Also, please address the open conversation with @SimonBarendse .
golangcibot
reviewed
Feb 18, 2020
Member
|
Code-wise 👍 @florisvdg did you do a functional review? |
florisvdg
approved these changes
Feb 20, 2020
Member
florisvdg
left a comment
florisvdg
left a comment
There was a problem hiding this comment.
Functionally works well too 👌
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.